-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appimageTools: init #54693
appimageTools: init #54693
Conversation
Tested with Etcher (Type1) and Patchwork (Type2), but not far beyond "it runs and looks okay". Please try on AppImages you use and report any issues. |
b63377f
to
2eca5ce
Compare
2eca5ce
to
02ed28d
Compare
Tested on |
I'd love to try this PR out, it's just I don't know how to, as I am still pretty inexperienced with Nix. I tried adding my clone of your fork, checked out to appimage-tool, to my overlays.nix file (which looks like https://gist.github.com/437e361011def183f124f7eb00042643) but running |
02ed28d
to
66eff82
Compare
@fusion809 |
I read the code, I didn't understand everything (I'm still a noob with Nix) I don't know how to use it, because:
|
@pinage404 You can use the standardnotes PR referenced above as an example. You would have to copy (I will do docs Soon™) |
66eff82
to
192471f
Compare
The appimageTools attrset contains utilities to prevent the usage of appimage-run to package AppImages, like done/attempted in NixOS#49370 and NixOS#53156. This has the advantage of allowing for per-package environment changes, and extracts into the store instead of the users home directory. The package list was extracted into appimageTools to prevent duplication.
192471f
to
58443d8
Compare
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/nixos-19-03-feature-freeze/1950/34 |
Motivation for this change
The appimageTools attrset contains utilities to prevent
the usage of appimage-run to package AppImages, like done/attempted
in #49370 and #53156.
This has the advantage of allowing for per-package environment changes,
and extracts into the store instead of the users home directory.
The package list was extracted into appimageTools to prevent
duplication.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)