Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appimageTools: init #54693

Merged
merged 1 commit into from
Feb 23, 2019
Merged

appimageTools: init #54693

merged 1 commit into from
Feb 23, 2019

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Jan 27, 2019

Motivation for this change

The appimageTools attrset contains utilities to prevent
the usage of appimage-run to package AppImages, like done/attempted
in #49370 and #53156.

This has the advantage of allowing for per-package environment changes,
and extracts into the store instead of the users home directory.

The package list was extracted into appimageTools to prevent
duplication.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tilpner
Copy link
Member Author

tilpner commented Jan 27, 2019

Tested with Etcher (Type1) and Patchwork (Type2), but not far beyond "it runs and looks okay". Please try on AppImages you use and report any issues.

@joepie91 @fusion809 @tycho01 @pinage404

@tilpner tilpner force-pushed the appimage-tools branch 2 times, most recently from b63377f to 2eca5ce Compare January 27, 2019 13:30
@tilpner tilpner changed the title appimageTools: init [WIP] appimageTools: init Jan 27, 2019
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 27, 2019
@tilpner tilpner changed the title [WIP] appimageTools: init appimageTools: init Jan 27, 2019
@cocreature
Copy link
Contributor

Tested on bitwarden and it worked just fine so 👍

@fusion809
Copy link
Contributor

I'd love to try this PR out, it's just I don't know how to, as I am still pretty inexperienced with Nix. I tried adding my clone of your fork, checked out to appimage-tool, to my overlays.nix file (which looks like https://gist.github.com/437e361011def183f124f7eb00042643) but running nix-env -f '<nixos-unstable>' -iA appimageTools produces no output. Is this something to add to packages = [ ... ]; under my user account in /etc/nixos/configuration.nix, or?

@tilpner
Copy link
Member Author

tilpner commented Feb 1, 2019

@fusion809 appimageTools is meant to be used to package/wrap an AppImage file, so you'd use it from a Nix file, not nix-env. See #54696 for an example of how it can be used. Such an expression could live in nixpkgs, or in your overlay, and the result could then be installed as usual (nix-env, configuration.nix, etc.).

@pinage404
Copy link
Contributor

I read the code, I didn't understand everything (I'm still a noob with Nix)

I don't know how to use it, because:

  • I'm not a package developer (for the moment), so the way to do it is still unclear to me
  • I don't know how to use the code of this repo when it is not yet merged and therefore available in the unstable channel

@tilpner
Copy link
Member Author

tilpner commented Feb 14, 2019

@pinage404 You can use the standardnotes PR referenced above as an example. You would have to copy appimageTools to your machine manually, or work from my nixpkgs branch.

(I will do docs Soon™)

@GrahamcOfBorg GrahamcOfBorg added the 8.has: documentation This PR adds or changes documentation label Feb 23, 2019
The appimageTools attrset contains utilities to prevent
the usage of appimage-run to package AppImages, like done/attempted
in NixOS#49370 and NixOS#53156.

This has the advantage of allowing for per-package environment changes,
and extracts into the store instead of the users home directory.

The package list was extracted into appimageTools to prevent
duplication.
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixos-19-03-feature-freeze/1950/34

@grahamc grahamc closed this Feb 23, 2019
@grahamc grahamc reopened this Feb 23, 2019
@dtzWill dtzWill mentioned this pull request Feb 23, 2019
10 tasks
@grahamc grahamc merged commit 695fb80 into NixOS:master Feb 23, 2019
@bricewge bricewge mentioned this pull request Apr 7, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants