Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Git-Town Package #54732

Merged
merged 12 commits into from
Feb 8, 2019
Merged

Add Git-Town Package #54732

merged 12 commits into from
Feb 8, 2019

Conversation

allonsy
Copy link
Contributor

@allonsy allonsy commented Jan 27, 2019

Motivation for this change

Add the git-town package to the nixpkgs channel: https://github.com/originate/git-town

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@allonsy
git-town: init at 7.2.0
5929a63 
add git-town package derivation
@allonsy
git-town: init at 7.2.0
be5694c 
change to full build process
@allonsy
git-town: init at 7.2.0
1407b31 
add some newlines
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 27, 2019
@allonsy
git-town: init at 7.2.0
3705ba5 
use buildGoPackage
@allonsy
Copy link
Contributor Author

allonsy commented Jan 27, 2019

@symphorien
Made changes to address your comments.
Thanks for the suggestions!

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jan 27, 2019
@allonsy
git-town: init as 7.2.0
a641ca1 
remove unneeded install.bash
@allonsy
git-town: init at 7.2.0
9337972 
fix array params
@allonsy
git-town: init at 7.2.0
ee312af 
add allonsy as maintainer
@allonsy
git-town: init at 7.2.0
d7bdff8 
add allonsy as git-town maintainer
@allonsy
git-town: init at 7.2.0
f1653f4 
fix maintainers section
@allonsy
git-town: init at 7.2.0
cd1d83f 
various cleanup
@allonsy
git-town: init at 7.2.0
f12c2b7 
various cleanup
@allonsy
git-town: init at 7.2.0
f80a30b 
reorder handles and clean up imports
@infinisil
Copy link
Member

@GrahamcOfBorg eval

(ignore this, I broke eval for a bit)

@allonsy
Copy link
Contributor Author

allonsy commented Jan 30, 2019

@symphorien any more comments?

@allonsy
Copy link
Contributor Author

allonsy commented Feb 5, 2019

@symphorien ready to merge?

@symphorien
Copy link
Member

Looks good to me, but I don't have merge rights.

@matthewbauer matthewbauer merged commit b4178f2 into NixOS:master Feb 8, 2019
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@allonsy @infinisil @symphorien @matthewbauer @GrahamcOfBorg @Janik-Haag