Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt59: 5.9.3 -> 5.9.7 #54787

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@FlorianFranzen
Copy link
Contributor

commented Jan 28, 2019

Motivation for this change

Updates Qt 5.9.3 to 5.9.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl

This comment was marked as outdated.

Copy link
Member

commented Jan 28, 2019

@GrahamcOfBorg build qt59.full
@GrahamcOfBorg build qt59.qmake
@GrahamcOfBorg build qt59.qtbase
@GrahamcOfBorg build qt59.qtcharts
@GrahamcOfBorg build qt59.qtconnectivity
@GrahamcOfBorg build qt59.qtdeclarative
@GrahamcOfBorg build qt59.qtdoc
@GrahamcOfBorg build qt59.qtgraphicaleffects
@GrahamcOfBorg build qt59.qtimageformats
@GrahamcOfBorg build qt59.qtlocation
@GrahamcOfBorg build qt59.qtmacextras
@GrahamcOfBorg build qt59.qtmultimedia
@GrahamcOfBorg build qt59.qtquickcontrols
@GrahamcOfBorg build qt59.qtquickcontrols2
@GrahamcOfBorg build qt59.qtscript
@GrahamcOfBorg build qt59.qtsensors
@GrahamcOfBorg build qt59.qtserialport
@GrahamcOfBorg build qt59.qtsvg
@GrahamcOfBorg build qt59.qttools
@GrahamcOfBorg build qt59.qttranslations
@GrahamcOfBorg build qt59.qtvirtualkeyboard
@GrahamcOfBorg build qt59.qtwayland
@GrahamcOfBorg build qt59.qtwebchannel
@GrahamcOfBorg build qt59.qtwebengine
@GrahamcOfBorg build qt59.qtwebkit
@GrahamcOfBorg build qt59.qtwebsockets
@GrahamcOfBorg build qt59.qtx11extras
@GrahamcOfBorg build qt59.qtxmlpatterns

@FlorianFranzen

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2019

Looks like I will have to reworks some of the Darwin patches.

Revert "qt59-qtbase: fix darwin build with clang-5"
The fix is already included in Qt 5.9.7

This reverts commit 0bf153f.
@veprbl

This comment was marked as outdated.

Copy link
Member

commented Jan 29, 2019

@GrahamcOfBorg build qt59.full
@GrahamcOfBorg build qt59.qmake
@GrahamcOfBorg build qt59.qtbase
@GrahamcOfBorg build qt59.qtcharts
@GrahamcOfBorg build qt59.qtconnectivity
@GrahamcOfBorg build qt59.qtdeclarative
@GrahamcOfBorg build qt59.qtdoc
@GrahamcOfBorg build qt59.qtgraphicaleffects
@GrahamcOfBorg build qt59.qtimageformats
@GrahamcOfBorg build qt59.qtlocation
@GrahamcOfBorg build qt59.qtmacextras
@GrahamcOfBorg build qt59.qtmultimedia
@GrahamcOfBorg build qt59.qtquickcontrols
@GrahamcOfBorg build qt59.qtquickcontrols2
@GrahamcOfBorg build qt59.qtscript
@GrahamcOfBorg build qt59.qtsensors
@GrahamcOfBorg build qt59.qtserialport
@GrahamcOfBorg build qt59.qtsvg
@GrahamcOfBorg build qt59.qttools
@GrahamcOfBorg build qt59.qttranslations
@GrahamcOfBorg build qt59.qtvirtualkeyboard
@GrahamcOfBorg build qt59.qtwayland
@GrahamcOfBorg build qt59.qtwebchannel
@GrahamcOfBorg build qt59.qtwebengine
@GrahamcOfBorg build qt59.qtwebkit
@GrahamcOfBorg build qt59.qtwebsockets
@GrahamcOfBorg build qt59.qtx11extras
@GrahamcOfBorg build qt59.qtxmlpatterns

@FlorianFranzen

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@veprbl Thanks, good catch. It seems to build on Darwin now as well. Looks like a few build workers reset though.

@veprbl

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

I ran nix-review on linux, the only build failure is csound-qt, but it's not due to this PR: https://hydra.nixos.org/job/nixpkgs/trunk/csound-qt.x86_64-linux/all?page=1

@veprbl

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

Ok, let's merge. I will take a look again once hydra updates the cache.

@veprbl veprbl merged commit 571e44b into NixOS:master Jan 29, 2019

82 of 94 checks passed

qt59.full on x86_64-darwin No attempt
Details
qt59.full on x86_64-linux Timed out, unknown build status
Details
qt59.qtconnectivity on x86_64-darwin No attempt
Details
qt59.qtlocation on x86_64-linux Timed out, unknown build status
Details
qt59.qtmacextras on aarch64-linux No attempt
Details
qt59.qtmacextras on x86_64-linux No attempt
Details
qt59.qtscript on x86_64-linux Timed out, unknown build status
Details
qt59.qtwayland on x86_64-darwin No attempt
Details
qt59.qtwebengine on x86_64-darwin Failure
Details
qt59.qtwebengine on x86_64-linux Timed out, unknown build status
Details
qt59.qtwebkit on x86_64-darwin Timed out, unknown build status
Details
qt59.qtwebkit on x86_64-linux Timed out, unknown build status
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
qt59.full on aarch64-linux Success
Details
qt59.qmake on aarch64-linux Success
Details
qt59.qmake on x86_64-darwin Success
Details
qt59.qmake on x86_64-linux Success
Details
qt59.qtbase on aarch64-linux Success
Details
qt59.qtbase on x86_64-darwin Success
Details
qt59.qtbase on x86_64-linux Success
Details
qt59.qtcharts on aarch64-linux Success
Details
qt59.qtcharts on x86_64-darwin Success
Details
qt59.qtcharts on x86_64-linux Success
Details
qt59.qtconnectivity on aarch64-linux Success
Details
qt59.qtconnectivity on x86_64-linux Success
Details
qt59.qtdeclarative on aarch64-linux Success
Details
qt59.qtdeclarative on x86_64-darwin Success
Details
qt59.qtdeclarative on x86_64-linux Success
Details
qt59.qtdoc on aarch64-linux Success
Details
qt59.qtdoc on x86_64-darwin Success
Details
qt59.qtdoc on x86_64-linux Success
Details
qt59.qtgraphicaleffects on aarch64-linux Success
Details
qt59.qtgraphicaleffects on x86_64-darwin Success
Details
qt59.qtgraphicaleffects on x86_64-linux Success
Details
qt59.qtimageformats on aarch64-linux Success
Details
qt59.qtimageformats on x86_64-darwin Success
Details
qt59.qtimageformats on x86_64-linux Success
Details
qt59.qtlocation on aarch64-linux Success
Details
qt59.qtlocation on x86_64-darwin Success
Details
qt59.qtmacextras on x86_64-darwin Success
Details
qt59.qtmultimedia on aarch64-linux Success
Details
qt59.qtmultimedia on x86_64-darwin Success
Details
qt59.qtmultimedia on x86_64-linux Success
Details
qt59.qtquickcontrols on aarch64-linux Success
Details
qt59.qtquickcontrols on x86_64-darwin Success
Details
qt59.qtquickcontrols on x86_64-linux Success
Details
qt59.qtquickcontrols2 on aarch64-linux Success
Details
qt59.qtquickcontrols2 on x86_64-darwin Success
Details
qt59.qtquickcontrols2 on x86_64-linux Success
Details
qt59.qtscript on aarch64-linux Success
Details
qt59.qtscript on x86_64-darwin Success
Details
qt59.qtsensors on aarch64-linux Success
Details
qt59.qtsensors on x86_64-darwin Success
Details
qt59.qtsensors on x86_64-linux Success
Details
qt59.qtserialport on aarch64-linux Success
Details
qt59.qtserialport on x86_64-darwin Success
Details
qt59.qtserialport on x86_64-linux Success
Details
qt59.qtsvg on aarch64-linux Success
Details
qt59.qtsvg on x86_64-darwin Success
Details
qt59.qtsvg on x86_64-linux Success
Details
qt59.qttools on aarch64-linux Success
Details
qt59.qttools on x86_64-darwin Success
Details
qt59.qttools on x86_64-linux Success
Details
qt59.qttranslations on aarch64-linux Success
Details
qt59.qttranslations on x86_64-darwin Success
Details
qt59.qttranslations on x86_64-linux Success
Details
qt59.qtvirtualkeyboard on aarch64-linux Success
Details
qt59.qtvirtualkeyboard on x86_64-darwin Success
Details
qt59.qtvirtualkeyboard on x86_64-linux Success
Details
qt59.qtwayland on aarch64-linux Success
Details
qt59.qtwayland on x86_64-linux Success
Details
qt59.qtwebchannel on aarch64-linux Success
Details
qt59.qtwebchannel on x86_64-darwin Success
Details
qt59.qtwebchannel on x86_64-linux Success
Details
qt59.qtwebengine on aarch64-linux Success
Details
qt59.qtwebkit on aarch64-linux Success
Details
qt59.qtwebsockets on aarch64-linux Success
Details
qt59.qtwebsockets on x86_64-darwin Success
Details
qt59.qtwebsockets on x86_64-linux Success
Details
qt59.qtx11extras on aarch64-linux Success
Details
qt59.qtx11extras on x86_64-darwin Success
Details
qt59.qtx11extras on x86_64-linux Success
Details
qt59.qtxmlpatterns on aarch64-linux Success
Details
qt59.qtxmlpatterns on x86_64-darwin Success
Details
qt59.qtxmlpatterns on x86_64-linux Success
Details

@veprbl veprbl self-assigned this Jan 29, 2019

@veprbl

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

One build failure so far complains about the hash of a tarball:
https://hydra.nixos.org/build/88060633
This is fine when I do it locally and it was fine when ofborg built it. Will wait to see if it goes away.

@veprbl

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

In light of #54986 this needs to be backported Backported in #55089

@FlorianFranzen FlorianFranzen deleted the FlorianFranzen:qt59 branch Feb 10, 2019

@veprbl veprbl removed their assignment Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.