Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openra: updated engines and mods #54858

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
3 participants
@msteen
Copy link
Contributor

commented Jan 29, 2019

Motivation for this change

The bleed version of OpenRA had the wrong hash and most mods have had updates. The Zenity error now shows actual newlines rather than \n. Mods have been updated automatically with a script, which is included in the PR.

Update 2: Downgraded kknd to a older commit and upgraded dr to an even newer commit to make them both work. They should now all run.
Update: @fusion809 tested them and found that only kknd and dr need fixing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@msteen msteen force-pushed the msteen:openra branch from b61b3e2 to 8502b79 Jan 29, 2019

@msteen msteen force-pushed the msteen:openra branch 5 times, most recently from 881abb5 to 5458276 Jan 29, 2019

@msteen msteen force-pushed the msteen:openra branch from 5458276 to cca9df9 Jan 30, 2019

@fpletz

fpletz approved these changes Feb 3, 2019

Copy link
Member

left a comment

Awesome, thanks!

@fpletz fpletz merged commit 92e64d5 into NixOS:master Feb 3, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.