Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awesome: 4.2 -> 4.3, don't clutter PATH, touchup lua paths #54867

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
4 participants
@dtzWill
Copy link
Contributor

commented Jan 29, 2019

Motivation for this change

Should be compatible but even so may want to review
release notes to take advantage of the new goodness:

https://github.com/awesomeWM/awesome/releases/tag/v4.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dtzWill added some commits Jan 28, 2019

awesome: fixup lua paths, don't add random utilities to PATH
Lua path changes needed to fix build,
removing PATH clutter while visiting this code since doesn't belong.
@rasendubi
Copy link
Member

left a comment

This looks awesome!

@rasendubi

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

Running awesome-4.3 right now. Works like a charm.

@rasendubi rasendubi merged commit c19693b into NixOS:master Jan 29, 2019

12 of 13 checks passed

awesome on x86_64-darwin No attempt
Details
awesome on aarch64-linux Success
Details
awesome on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@psychon

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

Uhm, asciidoc was replaced with asciidoctor (due to asciidoc being deprecated), thus asciidoc can be removed from the build inputs.

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

Uhm, asciidoc was replaced with asciidoctor (due to asciidoc being deprecated), thus asciidoc can be removed from the build inputs.

Whoops, sorry! Will submit a PR fixing this shortly :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.