New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.scikit-build: init at 0.8.1 #54890

Merged
merged 2 commits into from Feb 14, 2019

Conversation

Projects
None yet
4 participants
@FlorianFranzen
Copy link
Contributor

FlorianFranzen commented Jan 29, 2019

Motivation

Tool to build easily build Python extensions with CMake.

Things done

Included patch was submitted upstream and is part of next release.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 29, 2019

Could not find suitable distribution for Requirement.parse('pytest-runner<3dev,>=2.0')

You will need to patch the source to allow a more recent version of pytest-runner.

@dotlambda dotlambda changed the title pythonPackage.scikit-build: init of 0.8.1 pythonPackages.scikit-build: init at 0.8.1 Jan 29, 2019

@FlorianFranzen FlorianFranzen force-pushed the FlorianFranzen:scikit-build branch from 80943df to ae1f3c1 Jan 30, 2019

@FlorianFranzen

This comment has been minimized.

Copy link
Contributor Author

FlorianFranzen commented Jan 30, 2019

I updated the expression, but the tests now triggers a bug in the way python3 is build at the moment.

On an older NixOS system:

$ python3 -c 'import sysconfig; print(sysconfig.get_config_var("INCLUDEPY"))' 
/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/include/python3.6m

On the current unstable channel:

$ nix-shell --pure -p python36 --run "python3 -c 'import sysconfig; print(sysconfig.get_config_var(\"INCLUDEPY\"))'"
/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-python3-3.6.8/include/python3.6m

I will triage the source of the issue a bit longer, but it seems like nuke-references breaks sysconfig at the moment.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 30, 2019

That will be fixed by #54486.

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Feb 7, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/cannot-link-against-python/2054/2

@FlorianFranzen

This comment has been minimized.

Copy link
Contributor Author

FlorianFranzen commented Feb 10, 2019

So I guess we will have to wait for staging to be merged into master, before we can run these test again. Not to mention that I am still waiting to be added as a maintainer in a previous pull-request.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 10, 2019

You can also make your PR against staging.

@FlorianFranzen FlorianFranzen force-pushed the FlorianFranzen:scikit-build branch from ae1f3c1 to 74251bc Feb 14, 2019

@FlorianFranzen FlorianFranzen changed the base branch from master to staging-next Feb 14, 2019

@FlorianFranzen

This comment has been minimized.

Copy link
Contributor Author

FlorianFranzen commented Feb 14, 2019

@dotlambda: True, that is probably the easiest.

Now with staging-next as base and the missing maintainer entry.

@FlorianFranzen FlorianFranzen force-pushed the FlorianFranzen:scikit-build branch from 74251bc to 55ab920 Feb 14, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 14, 2019

@GrahamcOfBorg build python2.pkgs.scikit-build python3.pkgs.scikit-build

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 14, 2019

@GrahamcOfBorg build python2.pkgs.scikit-build

@dotlambda
Copy link
Member

dotlambda left a comment

Btw, adding yourself to maintainer-list.nix should be a separate commit.

@FlorianFranzen FlorianFranzen force-pushed the FlorianFranzen:scikit-build branch 2 times, most recently from f8475b3 to f625b18 Feb 14, 2019

@FlorianFranzen FlorianFranzen force-pushed the FlorianFranzen:scikit-build branch from f625b18 to c62202c Feb 14, 2019

@FlorianFranzen

This comment has been minimized.

Copy link
Contributor Author

FlorianFranzen commented Feb 14, 2019

I split the commit in two and added the missing spelling correction.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 14, 2019

@FlorianFranzen Thank you for your patience!

@GrahamcOfBorg build python2.pkgs.scikit-build

@dotlambda dotlambda merged commit f0edf20 into NixOS:staging-next Feb 14, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@FlorianFranzen

This comment has been minimized.

Copy link
Contributor Author

FlorianFranzen commented Feb 14, 2019

@dotlambda No problem. I was the one who pushed a broken commit.

The Python 3 builds are the most important ones, as the scikit-build testsuite will tell if Python's sysconfig is working (fixed by #54486, which was merged into unstable-next).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment