Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initrd: Fixed to include/use modprobe config files #54891

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dguibert
Copy link
Member

commented Jan 29, 2019

The patch reintroduces modprobe nixos config that has been deactivate by 4a4c051.
It has been removed since the firmware was included in the initrd
(inflating it by more than 120M). With this patch, the firmware is not added to the initrd closure but the modules are loaded with the same options as defined inside configuration.nix.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

initrd: Fixed to include/use modprobe config files
The patch reintroduces modprobe nixos config that has been deactivate by 4a4c051.
It has been removed since the firmware was included in the initrd
(inflating it by more than 120M).

The firmware is removed from the initrd closure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.