Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir: remember where a package is defined #54892

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@grahamc
Copy link
Member

commented Jan 29, 2019

Motivation for this change

A bunch of human-facing things around Nixpkgs depend on knowing where a package was defined. This PR makes it so ofborg can ping elixir maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

also lol at not spelling elixir right.

elixir: remember where a package is defined
A bunch of human-facing things around Nixpkgs depend on knowing where
a package was defined. This PR makes it so ofborg can ping elixir
maintainers.

@grahamc grahamc force-pushed the grahamc:elixer-maintainer-ping branch from 97c50ca to 18993b3 Jan 29, 2019

@grahamc grahamc changed the title elixer: remember where a package is defined elixir: remember where a package is defined Jan 29, 2019

@grahamc grahamc merged commit fb7ffda into NixOS:master Jan 29, 2019

12 checks passed

elixir on aarch64-linux Success
Details
elixir on x86_64-darwin Success
Details
elixir on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@grahamc grahamc deleted the grahamc:elixer-maintainer-ping branch Jan 29, 2019

@matthewbauer

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Do you have the same issue with ghc / or anything else? Trying to see how extensive the issue is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.