Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tt-rss: 2018-04-05 -> 2019-01-29 #54896

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
3 participants
@Nadrieril
Copy link
Contributor

commented Jan 29, 2019

Motivation for this change

Simple update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Infinisil

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

[x] Tested execution of all binary files (usually in ./result/bin/)

This is just a bunch of html and javascript.. Please actually read the checkmarks and test stuff properly.

tt-rss has a NixOS module, you should check to make sure it works with the new version.

@Nadrieril

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

I assumed the checkmark covered whatever notion of "running it" made sense. I did test the nixos module on my server in production and it works fine.

@Infinisil

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

I see, thanks :)

@Infinisil Infinisil merged commit 7e3647c into NixOS:master Jan 30, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

dasJ added a commit to dasJ/nixpkgs that referenced this pull request Feb 17, 2019

tt-rss-plugin-tumblr-gdpr: Update to 2.1
The old version doesn't work anymore since NixOS#54896 was merged.

dasJ added a commit to dasJ/nixpkgs that referenced this pull request Feb 17, 2019

tt-rss-plugin-tumblr-gdpr: 1.2 -> 2.1
The old version doesn't work anymore since NixOS#54896 was merged.

dasJ added a commit to dasJ/nixpkgs that referenced this pull request Feb 17, 2019

tt-rss-plugin-tumblr-gdpr: 1.2 -> 2.1
The old version doesn't work anymore since NixOS#54896 was merged.

dasJ added a commit to dasJ/nixpkgs that referenced this pull request Feb 17, 2019

tt-rss-plugin-tumblr-gdpr: 1.2 -> 2.1
The old version doesn't work anymore since NixOS#54896 was merged.

@dasJ dasJ referenced this pull request Feb 17, 2019

Merged

tt-rss-plugin-tumblr-gdpr: 1.2 -> 2.1 #55934

4 of 10 tasks complete

dasJ added a commit to dasJ/nixpkgs that referenced this pull request Feb 17, 2019

tt-rss-theme-feedly: 1.4.0 -> 2.0.0
The old version doesn't work anymore since NixOS#54896 was merged.

@dasJ dasJ referenced this pull request Feb 17, 2019

Merged

tt-rss-theme-feedly: 1.4.0 -> 2.0.0 #55937

4 of 10 tasks complete

FRidh added a commit that referenced this pull request Feb 17, 2019

tt-rss-theme-feedly: 1.4.0 -> 2.0.0
The old version doesn't work anymore since #54896 was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.