Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

androidenv: move licenseAccepted condition to androidsdk #54915

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

matthewbauer
Copy link
Member

I noticed that the Android stuff was not being built on hydra. The NDK can be used without accepting the SDK license. This moves that condition to androidsdk.

The NDK can be built without accepting the license.
@svanderburg
Copy link
Member

svanderburg commented Jan 30, 2019 via email

@matthewbauer
Copy link
Member Author

Yeah it gets kind of awkward with determining each of these right now. I think the situation can improve over time though.

The end goal will be to make a fully built Android toolchain. We are already like 90% of the way there. The big thing left is building BIONIC from source. But until then I want to make sure we keep most of Nixpkgs at least partly Android-compatible.

@matthewbauer matthewbauer merged commit 6182d28 into NixOS:master Jan 31, 2019
@matthewbauer matthewbauer deleted the rework-android-assert branch February 22, 2019 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants