Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clmagma: init at 1.3 #54967

Merged
merged 1 commit into from Jan 5, 2020
Merged

clmagma: init at 1.3 #54967

merged 1 commit into from Jan 5, 2020

Conversation

@volhovm
Copy link
Contributor

@volhovm volhovm commented Jan 30, 2019

Motivation for this change

CLMagma is introduced, as magma is only available for CUDA.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" doesn't apply
  • Tested execution of all binary files (usually in ./result/bin/) doesn't apply
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

@ryantm ryantm commented Feb 18, 2019

@GrahamcOfBorg build clmagma

@ryantm
Copy link
Member

@ryantm ryantm commented Feb 18, 2019

On a NixOS machine, I ran

nix-review pr 54967

and got this build failure

builder for '/nix/store/aa88m794ffdnhi3xnqhzi5wjxlry7k4i-clblas-2.12.drv' failed with exit code 2; last 10 log lines:
                                                 ~~~~~~~^
       ValuesIn(orderSet), ValuesIn(uploSet), ValuesIn(transSet),
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       Values(QUEUES_TEST_MATRIX_SIZES), Values(QUEUES_TEST_MATRIX_SIZES),
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       Values(clMath::ExtraTestSizes()), ValuesIn(numQueues)));
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  make[2]: *** [tests/CMakeFiles/test-medium.dir/build.make:700: tests/CMakeFiles/test-medium.dir/correctness/test-correctness.cpp.o] Error 1
  make[1]: *** [CMakeFiles/Makefile2:400: tests/CMakeFiles/test-medium.dir/all] Error 2
  make: *** [Makefile:152: all] Error 2
cannot build derivation '/nix/store/il4ixcf3l4hbqfmq3s1m8wa2gq5xi8jx-clmagma-1.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zjnr063zj7l275chdmn98b7dls5gm831-env.drv': 1 dependencies couldn't be built

It looks like there is some issue with clblas

@volhovm
Copy link
Contributor Author

@volhovm volhovm commented Feb 18, 2019

@ryantm Yes, clblas is broken on my machine too. It has some issues with the test suite and I have just disabled them in order to compile clmagma. I'm not sure I have time to debug clblas for now (that's why I didn't include it in the PR at all), but adding "-DBUILD_TEST=OFF" to the clblas's cmakeFlags is enough to test that clmagma builds properly.

@mmahut
Copy link
Member

@mmahut mmahut commented Aug 20, 2019

Are there any updates on this pull request, please?

@volhovm volhovm force-pushed the volhovm:volhovm/clmagma branch from 4a447e0 to 58dffa3 Aug 30, 2019
@volhovm
Copy link
Contributor Author

@volhovm volhovm commented Aug 30, 2019

Since 4c74ee9 fixed clblas (by disabling tests), this pull request can be now merged. Library builds on my computer without any extra patches. Sorry for the delay.

@ryantm ryantm merged commit f8cd096 into NixOS:master Jan 5, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.