Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify all the various
haskellSrc2nix
calls into a generic API that'smore convenient than
packageSourceOverrides
.Note: I am skeptical of this change. It does include a couple of rather complex functions, which could be too much. But after #52848, I started to feel like the variants were getting a little out of hand and needed unifying. In particular, this also adds fairly generic support for revisions.
/cc @shlevy @mightybyte @infinisil
Motivation for this change
This enables a pretty convenient alternative to
packageSourceOverrides
with a lot more power.I am open to better names. Not sure
generic*
really captures the purpose quite right.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)