Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: (re)take into account extraConfig #54977

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

teto
Copy link
Member

@teto teto commented Jan 31, 2019

PR #42838 wrongly started to ignore extraConfig. This fixes that.

Motivation for this change

Issue reported in #42838 (comment)

CC @lopsided98

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

PR NixOS#42838 wrongly started to ignore extraConfig. This fixes that.
@teto
Copy link
Member Author

teto commented Jan 31, 2019

CC @infinisil

@joachifm joachifm merged commit bc84a22 into NixOS:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants