Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: disable package registry #54982

Closed
wants to merge 1 commit into from

Conversation

FlorianFranzen
Copy link
Contributor

Motivation for this change

Following CMakes own recommendation, we should disable the package registry in nix builds:
https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#disabling-the-package-registry

For builds were no home folder is available, the change seems to be mostly cosmetic, as it just removes warning messages, but in the opposite case the package registry would allow CMake to build against arbitrary packages in the registry.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea.

@LnL7
Copy link
Member

LnL7 commented Jan 31, 2019

This rebuilds a lot of packages so it should go to staging first.

@FlorianFranzen
Copy link
Contributor Author

@LnL7 Ok, that I can do.

Replaced by pull request #55046.

@FlorianFranzen FlorianFranzen deleted the cmake_no_pkg_reg branch February 10, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants