Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taffybar: Remove strictDeps and restore overrideAttrs #54989

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jan 31, 2019

Motivation for this change

Get rid of now-unnecessary overrides for strictDeps and pkgconfig gtk3, restoring overrideAttrs.

taffybar still does not compile because the current Hackage release does not support gi-gdkpixbuf > 0.16 but should be fine with the next release, eg. this overlay builds, or one that downgrades gi-gdkpixbuf:

  haskellPackages = with self.haskell.lib; super.haskellPackages.extend (hself: hsuper: {
    # Supports gi-gdkpixbuf 2.0.18
    taffybar = if !(hsuper.taffybar.version == "3.1.1")
    then "taffybar overlay out of date"
    else (
      hsuper.taffybar.overrideAttrs (oa : {
        src = self.fetchFromGitHub {
          owner = "taffybar";
          repo = "taffybar";
          rev = "e382599358bb06383ba4b08d469fc093c11f5915";
          sha256 = "0qncwpfz0v2b6nbdf7qgzl93kb30yxznkfk49awrz8ms3pq6vq6g";
        };
      })
    );
  });

cc @puffnfresh so you can confirm that it's safe to get rid of strictDeps now. :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants