Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc2-headless: 3.17 -> 4.7.1 #54991

Merged
merged 1 commit into from Feb 12, 2019
Merged

sc2-headless: 3.17 -> 4.7.1 #54991

merged 1 commit into from Feb 12, 2019

Conversation

@FlorianFranzen
Copy link
Contributor

@FlorianFranzen FlorianFranzen commented Jan 31, 2019

Motivation for this change

Fixes #54964

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@alyssais
Copy link
Member

@alyssais alyssais commented Jan 31, 2019

@GrahamcOfBorg build sc2-headless

@spacekitteh
Copy link
Contributor

@spacekitteh spacekitteh commented Feb 4, 2019

LGTM

@spacekitteh
Copy link
Contributor

@spacekitteh spacekitteh commented Feb 10, 2019

@grahamc any chance this can be merged?

@FlorianFranzen
Copy link
Contributor Author

@FlorianFranzen FlorianFranzen commented Feb 10, 2019

@alyssais That will not do anything, unless nix in configured with sc2-headless.accept_license = true;.

@spacekitteh
Copy link
Contributor

@spacekitteh spacekitteh commented Feb 10, 2019

Hmm, if this gets merged I'll try and add the map packs as well (when I eventually can use nix on a local machine, anyway!)

@srhb srhb merged commit c0cfe9b into NixOS:master Feb 12, 2019
12 checks passed
@FlorianFranzen FlorianFranzen deleted the sc2-headless branch Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants