Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-manager: 0.7.4.1 -> 0.7.4.2 #54997

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

wedens
Copy link

@wedens wedens commented Jan 31, 2019

Motivation for this change

Fixes mimeinfo.cache conflict (#54272 (comment)) and updates to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

also fixed mimeinfo.cache conflict when e.g. file-roller is installed
@dtzWill
Copy link
Member

dtzWill commented Jan 31, 2019

LGTM! There was discussion of possibly a setupHook for the mimeinfo.cache problem but this fixes the immediate problem and is simple to adjust (and harmless if we forget) should the setupHook approach be implemented in the future.

@dtzWill dtzWill merged commit 73d5530 into NixOS:master Jan 31, 2019
@wedens wedens deleted the fix-font-manager-conflict branch January 31, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants