Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picard: 2.1.0 -> 2.1.2 #55000

Merged
merged 3 commits into from
Jan 31, 2019
Merged

picard: 2.1.0 -> 2.1.2 #55000

merged 3 commits into from
Jan 31, 2019

Conversation

Anton-Latukha
Copy link
Contributor

Motivation for this change
  1. fetchurl -> fetchFromGitHub. Would allow autoupdates.
  2. 2.1.0 -> 2.1.2.
  3. Removed doCheck = false due to redundancy, according to NixPkgs manual, link.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Anton-Latukha
Copy link
Contributor Author

Celebrating #55000!

@dotlambda
Copy link
Member

@GrahamcOfBorg build picard

@dotlambda
Copy link
Member

Removed doCheck = false due to redundancy, according to NixPkgs manual

buildPython* is a special case, it sets doCheck = true by default. However, tests seem to work just fine.

@dotlambda dotlambda merged commit 52eb2c4 into NixOS:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants