Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

racket: remove x86_64-darwin from platforms #55005

Merged
merged 1 commit into from
Feb 1, 2019
Merged

racket: remove x86_64-darwin from platforms #55005

merged 1 commit into from
Feb 1, 2019

Conversation

clacke
Copy link
Contributor

@clacke clacke commented Jan 31, 2019

It does not build on this platform, and will not do so any time soon.

racket-minimal is not affected, as it already has its own
meta.platforms.

Closes #53389

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

Is removing Darwin as a platform really what we want to do here? Does Racket upstream support Darwin? If so, I think broken = stdenv.isDarwin would be more appropriate, since the lack of Darwin support is a Nixpkgs bug, rather than something fundamental to the package.

@clacke
Copy link
Contributor Author

clacke commented Feb 1, 2019

Wasn't aware of this distinction. Thanks! Will update.

@clacke clacke force-pushed the racket-full-no-darwin branch 2 times, most recently from 4cc3e24 to 4c155c2 Compare February 1, 2019 13:34
@clacke
racket: mark x86_64-darwin broken
45c0f89 
It does not build on this platform, and will not do so any time soon.

Closes NixOS#53389
@alyssais
Copy link
Member

alyssais commented Feb 1, 2019

@GrahamcOfBorg build racket
@GrahamcOfBorg build racket-minimal

@alyssais alyssais merged commit 4e270f9 into NixOS:master Feb 1, 2019
@clacke clacke deleted the racket-full-no-darwin branch February 1, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais requested changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clacke @alyssais @GrahamcOfBorg