Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ninja: 1.8.2 -> 1.9.0 #55008

Merged
merged 1 commit into from
Feb 2, 2019
Merged

ninja: 1.8.2 -> 1.9.0 #55008

merged 1 commit into from
Feb 2, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 31, 2019

https://groups.google.com/forum/#!topic/ninja-build/nY5Kb7zUvcg

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I have not tested any significant number of packages using it.
Not that there should be any problems... :)

@dtzWill dtzWill merged commit b6e50b3 into NixOS:staging Feb 2, 2019
@dtzWill dtzWill deleted the update/ninja-1.9.0 branch February 2, 2019 07:04
@vcunat vcunat mentioned this pull request Feb 2, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants