Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-sdk: 2.1.403 -> 2.1.503 and add dotnet: 2.1.7 #55013

Closed
wants to merge 3 commits into from
Closed

dotnet-sdk: 2.1.403 -> 2.1.503 and add dotnet: 2.1.7 #55013

wants to merge 3 commits into from

Conversation

ghuntley
Copy link
Member

@ghuntley ghuntley commented Jan 31, 2019 •
edited
Loading

Motivation for this change

Opening early.

  • dotnet-sdk: 2.1.403 -> 2.1.503 is ready for review
  • dotnet: 2.1.7 is ready for review

the dotnet runtime is a cutdown version of the sdk and does not need to be installed if the sdk is present.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghuntley
dotnet-sdk: bumped to v2.1.503
c668ae9 
dotnet: added runtime at v2.1.7

the dotnet runtime is a cutdown version of the sdk thus if the sdk is
installed then runtime does not need to be installed.
@ghuntley ghuntley changed the title [WIP] dotnet-sdk: 2.1.403 -> 2.1.503 and add dotnet: 2.1.7 dotnet-sdk: 2.1.403 -> 2.1.503 and add dotnet: 2.1.7 Feb 4, 2019
@joachifm
Copy link
Contributor

Needs a rebase

@ghuntley
Copy link
Member Author

Merge conflicts resolved.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@roberth
Copy link
Member

roberth commented Nov 10, 2020

dotnet-sdk: 2.1.403 -> 2.1.503 is ready for review
dotnet: 2.1.7 is ready for review

These are available. NixOS 20.09 has

nix-repl> dotnet-sdk.version
"2.1.804"

nix-repl> dotnet-aspnetcore.version
"2.1.16"

@roberth roberth closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ghuntley @joachifm @roberth @ryantm @infinisil @GrahamcOfBorg