Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roundcube: add support for third-party plugins #55017

Merged
merged 3 commits into from
Feb 8, 2019
Merged

roundcube: add support for third-party plugins #55017

merged 3 commits into from
Feb 8, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 31, 2019 •
edited
Loading

Motivation for this change

This aims to support roundcube with third-party plugins. Those plugins should be listed in the meta-package roundcubePlugins and can be added to the roundcube using roundcube.withPlugins.

I also packaged the persistent_login plugin to support a remember me checkbox in roundcube.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
roundcubePlugins: init
5b9e1df 
This meta-package is supposed to contain third-party roundcube plugins
such as `persistent_login` that will be linked into the roundcube
derivation.
@Ma27
roundcube: add withPlugins function
b3fb1ce 
This function creates a new store path with roundcube sources and all
specified plugins. It can be used like this:

```
roundcube.withPlugins (plugins: with plugins; [
  persistent_login
])
```
@Ma27
nixos/roundcube: add package option
55f449c 
With this option it's possible to specify a custom expression for
`roundcube`, i.e. a roundcube environment with third-party plugins as
shown in the testcase.
@Ma27 Ma27 requested a review from infinisil as a code owner January 31, 2019 22:31
@Ma27 Ma27 changed the title WIP roundcube: add support for third-party plugins roundcube: add support for third-party plugins Jan 31, 2019
@Ma27
Copy link
Member Author

Ma27 commented Jan 31, 2019

Also tested with my personal roundcube instance.

@Ma27 Ma27 requested a review from globin February 4, 2019 19:54
@globin globin merged commit 6fb825b into NixOS:master Feb 8, 2019
@Ma27 Ma27 deleted the roundcube-remember-me branch February 8, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ma27 @globin @GrahamcOfBorg