Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBSD cross compiling #55023

Merged
merged 2 commits into from Feb 26, 2019
Merged

NetBSD cross compiling #55023

merged 2 commits into from Feb 26, 2019

Conversation

@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Feb 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@Ericson2314 Ericson2314 left a comment

Awesome!!

@matthewbauer matthewbauer changed the title [wip] netbsd cross compiling netbsd cross compiling Feb 4, 2019
@matthewbauer matthewbauer changed the title netbsd cross compiling NetBSD cross compiling Feb 4, 2019
@matthewbauer matthewbauer changed the base branch from master to staging Feb 4, 2019
@matthewbauer matthewbauer changed the base branch from staging to master Feb 4, 2019
@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Feb 5, 2019

Wooo! Staging and then it's a-go? We should get this on some their mailing list or whatever. It should be a great way to draw in more people to Nix/Nixpkgs/NixOS.

pSub
pSub approved these changes Feb 5, 2019
@matthewbauer
Copy link
Member Author

@matthewbauer matthewbauer commented Feb 5, 2019

To avoid breaking anything I might wait until branching off for 19.03

@matthewbauer
Copy link
Member Author

@matthewbauer matthewbauer commented Feb 5, 2019

I also am trying to upstream the GCC patch here:

https://gcc.gnu.org/ml/gcc-patches/2019-02/msg00198.html

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Feb 6, 2019

Good luck with the upstream!

@matthewbauer matthewbauer force-pushed the netbsd branch 3 times, most recently from e21a930 to 93097e1 Feb 25, 2019
@Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 26, 2019

Hopefully easier then getting stuff into the LLVM.

@matthewbauer matthewbauer force-pushed the netbsd branch 2 times, most recently from f916304 to 1a34dd8 Feb 26, 2019
@matthewbauer matthewbauer changed the base branch from master to staging Feb 26, 2019
matthewbauer and others added 2 commits Feb 26, 2019
Using the + operator with throw doesn’t seems to work properly. You
need to use antiquotes here to get the targetPlatform config included.
@matthewbauer matthewbauer merged commit 51d6b84 into NixOS:staging Feb 26, 2019
10 checks passed
@@ -23258,8 +23260,10 @@ in

fts = if stdenv.hostPlatform.isMusl then netbsd.fts else null;

inherit (recurseIntoAttrs (callPackages ../os-specific/bsd { }))
netbsd;
netbsd = callPackages ../os-specific/bsd/netbsd {};
Copy link
Member

@vcunat vcunat Apr 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removed recurseIntoAttrs and thus the packages aren't built by Hydra anymore. Was that intentional?

@vcunat
Copy link
Member

@vcunat vcunat commented Apr 7, 2019

The bigger problem is that netbsd-make won't build on Darwin anymore, breaking lots of packages, e.g. https://hydra.nixos.org/job/nixpkgs/trunk/getent.x86_64-darwin

@vcunat
Copy link
Member

@vcunat vcunat commented Apr 7, 2019

Well, netbsd.make won't build even on x86_64-linux on current nixpkgs master (though the error message seems different).

@matthewbauer
Copy link
Member Author

@matthewbauer matthewbauer commented Apr 7, 2019

Very weird. I’ll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants