Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airsonic: Add virtualHost option to set up nginx virtual host #55024

Merged
merged 1 commit into from Feb 12, 2019

Conversation

@telotortium
Copy link
Contributor

@telotortium telotortium commented Feb 1, 2019

Modeled after nixos/modules/services/web-apps/tt-rss.nix. The setup is
slightly non-intuitive, so I think it's worth adding upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixos/modules/services/misc/airsonic.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/airsonic.nix Outdated Show resolved Hide resolved
Modeled after nixos/modules/services/web-apps/tt-rss.nix. The setup is
slightly non-intuitive, so I think it's worth adding upstream.
@telotortium telotortium force-pushed the airsonic-virtualHost branch from 75b3878 to 027d418 Feb 5, 2019
@telotortium
Copy link
Contributor Author

@telotortium telotortium commented Feb 11, 2019

Hi, could you please take another look at this?

fpletz
fpletz approved these changes Feb 12, 2019
@fpletz
Copy link
Member

@fpletz fpletz commented Feb 12, 2019

Thanks!

@fpletz fpletz merged commit adb837e into NixOS:master Feb 12, 2019
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants