Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-polly,clang-polly: Add llvm/clang variants w/polly support #55065

Merged
merged 2 commits into from Feb 25, 2019

Conversation

@dtzWill
Copy link
Contributor

dtzWill commented Feb 2, 2019

Motivation for this change

Polly is much easier to use when linked into llvm and friends.

Related: #20941.

We may want to enable it by default, unsure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dtzWill added 2 commits Feb 1, 2019
Don't enable by default yet, defer rebuilds.
* bit hacky re:overrides
* need to explicitly set cmake flags for clang to link in polly
@Mic92
Mic92 approved these changes Feb 2, 2019
@dtzWill dtzWill merged commit ed60483 into NixOS:master Feb 25, 2019
13 checks passed
13 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
llvm on aarch64-linux Success
Details
llvm on x86_64-darwin Success
Details
llvm on x86_64-linux Success
Details
@dtzWill dtzWill deleted the dtzWill:feature/llvm-clang-polly branch Feb 25, 2019
@o1lo01ol1o

This comment has been minimized.

Copy link

o1lo01ol1o commented May 27, 2019

@dtzWill I'm trying to use clang and polly in a shell, but clang doesn't recognize -polly. here's a gist: https://gist.github.com/o1lo01ol1o/4cec6a9fe06bef660dd981557bd37674

Do I have the correct packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.