Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urbit: 0.6.0 -> 0.7.1 #55100

Closed
wants to merge 1 commit into from
Closed

urbit: 0.6.0 -> 0.7.1 #55100

wants to merge 1 commit into from

Conversation

@bsima
Copy link
Contributor

bsima commented Feb 2, 2019

Motivation for this change

Minor version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu

This comment has been minimized.

Copy link
Contributor

etu commented Feb 3, 2019

@GrahamcOfBorg build urbit

@etu

This comment has been minimized.

Copy link
Contributor

etu commented Feb 3, 2019

The build failure seems to be new on aarch64: https://hydra.nixos.org/job/nixpkgs/staging/urbit.aarch64-linux

@bsima

This comment has been minimized.

Copy link
Contributor Author

bsima commented Feb 3, 2019

Looks like this is a known issue urbit/urbit#970

@bsima

This comment has been minimized.

Copy link
Contributor Author

bsima commented Feb 4, 2019

@etu: Is there a way to say something like platforms = [ linuxExceptAarch64 ]?

@etu

This comment has been minimized.

Copy link
Contributor

etu commented Feb 5, 2019

@bsima Usually we don't want to go break on one platform where it currently works. And usually we don't want to diverge the versions per platform.

But we usually try to see if upstream may have a patch or something that can be applied in the version in question so we can update the package and get on with it.

But from looking at the issue linked above it doesn't seem like upstream have made any statements other than putting labels on it...

@bsima

This comment has been minimized.

Copy link
Contributor Author

bsima commented Feb 6, 2019

@dpc dpc mentioned this pull request Feb 14, 2019
0 of 10 tasks complete
@ryantm

This comment has been minimized.

Copy link
Member

ryantm commented Feb 25, 2019

Closing in favor of #55743

@ryantm ryantm closed this Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.