Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boehmgc{,_766}: add space before appending to CFLAGS (only done w/musl) #55133

Merged
merged 2 commits into from Feb 12, 2019

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 3, 2019

Motivation for this change

Otherwise we risk creating a rather strange argument!

This was preventing boehmgc from finding libatomic_ops on 32bit arch
(pkgsCross.muslpi.boehmgc)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

@dtzWill dtzWill commented Feb 3, 2019

@GrahamcOfBorg build pkgsMusl.boehmgc pkgsCross.muslpi.boehmgc

@dtzWill dtzWill merged commit 92a54bd into NixOS:master Feb 12, 2019
15 checks passed
@dtzWill dtzWill deleted the fix/bdwgc-musl-cflags-space branch Feb 12, 2019
ivmai
Copy link
Contributor

ivmai commented on 0938316 Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these defines are not needed anymore (with gc-8.0.6 or later).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants