New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl8821ce: init at 5.2.5_1.26055.20180108 #55141

merged 2 commits into from Feb 12, 2019


None yet
3 participants
Copy link

hhm0 commented Feb 3, 2019

Motivation for this change

Adds driver for rtl8821ce wifi hardware, a common wireless device which is integrated in many laptops.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

In order for the system to automatically use the kernel module (driver), pkgs.linuxPackages.rtl8821ce needs to be added to boot.extraModulePackages (when tested on my machine). Otherwise, and insmod command has to be run with the nix store path of the module as an argument, in order to load the driver. Is this normal/how it should be, or is there something else I can do in the nixpkgs package to make the driver load automatically when rtl8821ce hardware is detected, so people won't have to add the package to boot.extraModulePackages in order to use the hardware on their machine?


hhm0 added some commits Feb 3, 2019

@samueldr samueldr merged commit 8568f68 into NixOS:master Feb 12, 2019

10 checks passed

grahamcofborg-eval ^.^!
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
grahamcofborg-eval-check-meta config.nix: checkMeta = true
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
grahamcofborg-eval-package-list nix-env -qa --json --file .
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment