Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.ms-python.python: 2018.12.1 -> 2019.4.12954 #55149

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@eadwu
Copy link
Contributor

commented Feb 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

Looks good, but isn't this broken as described in #53923?

@eadwu

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

Just tested on a random python file, it is broken and requires patching for the Jedi language server.

Starting Jedi Python language engine.
Error: Traceback (most recent call last):
  File "/nix/store/1xxi7wv4ih13qa49zf9wjr9hddhrs53h-vscode-insiders-extension-ms-python-python-2019.1.0/share/vscode-insiders/extensions/ms-python.python/pythonFiles/sortImports.py", line 11, in <module>
    import isort.main
  File "/nix/store/1xxi7wv4ih13qa49zf9wjr9hddhrs53h-vscode-insiders-extension-ms-python-python-2019.1.0/share/vscode-insiders/extensions/ms-python.python/pythonFiles/lib/python/isort/main.py", line 31, in <module>
    import setuptools
ModuleNotFoundError: No module named 'setuptools'

@eadwu eadwu changed the title vscode-extensions.ms-python.python: 2018.12.1 -> 2019.1.0 vscode-extensions.ms-python.python: 2018.12.1 -> 2019.2.5433 Mar 4, 2019

@eadwu eadwu force-pushed the eadwu:vscode-extensions.ms-python.python/2019.1.0 branch from e8a0da9 to a6a7f0b Mar 4, 2019

@veprbl

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

@eadwu Is this ready now?

@eadwu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Doesn't look like it, though I'll test it again tomorrow.

Still broken.

@eadwu eadwu force-pushed the eadwu:vscode-extensions.ms-python.python/2019.1.0 branch from a6a7f0b to b598023 Apr 1, 2019

@eadwu eadwu changed the title vscode-extensions.ms-python.python: 2018.12.1 -> 2019.2.5433 vscode-extensions.ms-python.python: 2018.12.1 -> 2019.3.6215 Apr 1, 2019

@eadwu eadwu changed the title vscode-extensions.ms-python.python: 2018.12.1 -> 2019.3.6215 vscode-extensions.ms-python.python: 2018.12.1 -> 2019.3.6352 Apr 7, 2019

@eadwu eadwu force-pushed the eadwu:vscode-extensions.ms-python.python/2019.1.0 branch from b598023 to 98a36b9 Apr 8, 2019

@eadwu eadwu changed the title vscode-extensions.ms-python.python: 2018.12.1 -> 2019.3.6352 vscode-extensions.ms-python.python: 2018.12.1 -> 2019.4.11987 Apr 29, 2019

@eadwu eadwu force-pushed the eadwu:vscode-extensions.ms-python.python/2019.1.0 branch from 98a36b9 to aebaa9e Apr 29, 2019

@veprbl veprbl referenced this pull request Apr 29, 2019

Open

vscode-extensions.ms-python: 2018.12.1 -> 2019.4.11987 #60428

3 of 10 tasks complete

@eadwu eadwu force-pushed the eadwu:vscode-extensions.ms-python.python/2019.1.0 branch from aebaa9e to 928979f May 6, 2019

@eadwu eadwu changed the title vscode-extensions.ms-python.python: 2018.12.1 -> 2019.4.11987 vscode-extensions.ms-python.python: 2018.12.1 -> 2019.4.12954 May 6, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

commented May 10, 2019

If anyone wants this to be working again, I'm pretty sure if they pick up #53923 and supply the requested changes it should work. (i think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.