Skip to content

iw: 4.14 -> 5.0.1 #55164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2019
Merged

iw: 4.14 -> 5.0.1 #55164

merged 2 commits into from
Feb 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested a review from viric February 4, 2019 04:23
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 4, 2019
@dtzWill dtzWill changed the title iw: 4.14 -> 5.0 iw: 4.14 -> 5.0.1 Feb 5, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Feb 5, 2019

Any concerns here?

@dtzWill dtzWill merged commit a808baa into NixOS:staging Feb 17, 2019
@dtzWill dtzWill deleted the update/iw-5 branch February 17, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzWill @GrahamcOfBorg