Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140 #55188

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@shmish111
Copy link

commented Feb 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

David Smith added some commits Feb 4, 2019

David Smith
bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140
An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel.

Depends on #55184
David Smith
nixos/bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140
An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel.

Depends on:
  #54996
  #55187
@@ -0,0 +1,24 @@
{ stdenv, fetchFromGitHub, buildGoPackage }:

buildGoPackage {

This comment has been minimized.

Copy link
@kalbasit

kalbasit Mar 21, 2019

Member

is this duplicating #55187? Can we please merge back into #54996 but have 3 separate commits? It's difficult to review or test the PRs as it.

@uri-canva

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

bazel-remote already exists at the top level:

bazel-remote = callPackage ../development/tools/build-managers/bazel/bazel-remote { };

You probably want to update/move the existing derivation rather than creating a new one.

@shmish111

This comment has been minimized.

Copy link
Author

commented Mar 22, 2019

I think this PR was created by mistake, sorry

@shmish111 shmish111 closed this Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.