Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nginx: support h2c #55192

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
5 participants
@w4
Copy link
Contributor

commented Feb 4, 2019

Motivation for this change

haproxy 1.9 supports interfacing with backends over plain HTTP/2 (without TLS), nginx also supports this feature but the service definition forces use of TLS to enable HTTP/2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Infinisil

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Commit message should have the nixos/nginx: prefix but otherwise this looks good :)

@w4 w4 force-pushed the JordanForks:master branch from 44257f8 to 04425c6 Mar 8, 2019

@w4

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

Oops yeah sorry about that, fixed

@w4 w4 changed the title nginx: support h2c nixos/nginx: support h2c Mar 8, 2019

@Infinisil Infinisil merged commit eeb3733 into NixOS:master Mar 8, 2019

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dhess

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Hi, this commit breaks vhosts that serve content on port 80 and don't auto-redirect to port 443, including Let's Encrypt ACME auto-renewal. Please see #57324.

@Izorkin

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

With this PR error worked no https sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.