Skip to content

openapi-generator-cli: init at 3.3.4 #55203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2019
Merged

openapi-generator-cli: init at 3.3.4 #55203

merged 1 commit into from
Feb 7, 2019

Conversation

Shou
Copy link
Contributor

@Shou Shou commented Feb 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 4, 2019
@Ma27 Ma27 force-pushed the init-openapi-generator branch from 7fe0fb6 to 07b0483 Compare February 7, 2019 20:00
@Ma27
Copy link
Member

Ma27 commented Feb 7, 2019

Tested locally. If pnameand version is set, you don't need to set name manually, I fixed that and force-pushed.

Let's wait for the eval and merge then :)

@Ma27 Ma27 merged commit f19c75f into NixOS:master Feb 7, 2019
@Ma27
Copy link
Member

Ma27 commented Feb 7, 2019

@Shou thanks!

@Shou Shou deleted the init-openapi-generator branch February 13, 2019 17:21
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shou @Ma27 @GrahamcOfBorg @Janik-Haag