Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fff: 2.0 -> 2.1 #55249

Merged
merged 1 commit into from Feb 6, 2019
Merged

fff: 2.0 -> 2.1 #55249

merged 1 commit into from Feb 6, 2019

Conversation

@tadeokondrak
Copy link
Member

@tadeokondrak tadeokondrak commented Feb 5, 2019

Motivation for this change

Version bump.

  • This package previously used bash instead of bashInteractive, which made tab completion not work.
  • installPhase removed because of an upstream Makefile addition
  • New dependencies and optional feature added
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

veprbl
veprbl approved these changes Feb 6, 2019
@veprbl veprbl merged commit 27c6ca9 into NixOS:master Feb 6, 2019
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants