Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes to tensorflow to release-18.09 #55257

Merged
merged 1 commit into from Feb 6, 2019

Conversation

@CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Feb 5, 2019

(cherry picked from commit 69af83b)

Motivation for this change

Otherwise tensorflow complains about:

tensorflow.python.framework.errors_impl.NotFoundError: libforestprotos.so: cannot open shared object file: No such file or directory
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CMCDragonkai CMCDragonkai requested a review from FRidh as a code owner Feb 5, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from abbradar Feb 5, 2019
@veprbl veprbl merged commit 8008d0b into NixOS:release-18.09 Feb 6, 2019
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants