Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncthing 1.0.0 -> 1.0.1 #55285

Merged
merged 1 commit into from Feb 12, 2019
Merged

syncthing 1.0.0 -> 1.0.1 #55285

merged 1 commit into from Feb 12, 2019

Conversation

@jabranham
Copy link
Contributor

@jabranham jabranham commented Feb 5, 2019

Motivation for this change

Update syncthing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

@flokli flokli commented Feb 11, 2019

@GrahamcOfBorg build syncthing

1 similar comment
@flokli
Copy link
Contributor

@flokli flokli commented Feb 12, 2019

@GrahamcOfBorg build syncthing

@jabranham
Copy link
Contributor Author

@jabranham jabranham commented Feb 12, 2019

Pinging @peterhoeg since you merged the last syncthing update. This one appears to build and run just fine.

@flokli flokli merged commit 73525ed into NixOS:master Feb 12, 2019
13 checks passed
@flokli
Copy link
Contributor

@flokli flokli commented Feb 12, 2019

It was built just fine - don't see a reason not to merge :-)

@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Feb 13, 2019

Sorry about the slow response time guys. Thanks for merging @flokli and @jabranham for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants