Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nccl: 2.1.4 -> 2.4.2-1 #55292

Merged
merged 1 commit into from Feb 10, 2019
Merged

nccl: 2.1.4 -> 2.4.2-1 #55292

merged 1 commit into from Feb 10, 2019

Conversation

@orivej
Copy link
Contributor

@orivej orivej commented Feb 6, 2019

Motivation for this change

Since 2.3, NCCL 2 is released under BSD 3-Clause and can be built from source.

I have defined nccl_cudatoolkit_9_0, 9 (currently 9.2) and 10 because these are the builds available at https://developer.nvidia.com/nccl/nccl-download (requires a free nvidia.com account). I have removed nccl_cudatoolkit_8, because although NCCL might be buildable with CUDA 8.0, cudatoolkit_8 is broken in Nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" nix-review
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

--

/cc @abbradar who has changed the maintainer from @hyphon81 to @mdaiter in 41abde9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants