Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option config.services.tt-rss.checkForUpdates (forced to false) #55301

Merged

Conversation

@telotortium
Copy link
Contributor

@telotortium telotortium commented Feb 6, 2019

Force this option to false. Leaving this as true (currently the default)
is dangerous. If the TT-RSS installation upgrades itself to a newer
version requiring a schema update, the installation will break the next
time the TT-RSS systemd service is restarted.

Ideally, the installation itself should be immutable (see
#55300).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Infinisil
Copy link
Member

@Infinisil Infinisil commented Feb 6, 2019

Needs a mkRemovedOptionModule

Force this option to false. Leaving this as true (currently the default)
is dangerous. If the TT-RSS installation upgrades itself to a newer
version requiring a schema update, the installation will break the next
time the TT-RSS systemd service is restarted.

Ideally, the installation itself should be immutable (see
NixOS#55300).
@telotortium telotortium force-pushed the tt-rss_disable_automatic_updates branch from 8b7c2b4 to eab69d9 Feb 6, 2019
@telotortium
Copy link
Contributor Author

@telotortium telotortium commented Feb 6, 2019

mkRemovedOptionModule added.

@telotortium
Copy link
Contributor Author

@telotortium telotortium commented Feb 11, 2019

Hi, could you please take another look at this?

@Infinisil Infinisil merged commit 8a5925b into NixOS:master Feb 14, 2019
10 checks passed
@Infinisil
Copy link
Member

@Infinisil Infinisil commented Feb 14, 2019

Oh it's too late now, but in the future please format your commit message according to the Contribution Guidelines, also linked to from the PR template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants