Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitkraken: 4.2.1 -> 4.2.2 & fix missing gsettings schemas #55308

Merged
merged 4 commits into from Feb 26, 2019

Conversation

@megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Feb 6, 2019

Motivation for this change

Update gitkraken 4.2.1 to 4.2.2
Fix gitkraken missing GSettings schemas

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@megheaiulian megheaiulian changed the title gitkraken: fix missing gsettings schemas gitkraken: 4.2.1 -> 4.2.2 & fix missing gsettings schemas Feb 9, 2019
@megheaiulian megheaiulian force-pushed the feature/gitraken-gsettings branch from 5bcbe57 to 7022210 Feb 20, 2019
@megheaiulian
Copy link
Contributor Author

@megheaiulian megheaiulian commented Feb 20, 2019

@worldofpeace Thank you for the feedback. I've updated the PR.

@megheaiulian
Copy link
Contributor Author

@megheaiulian megheaiulian commented Feb 26, 2019

@Mic92 @worldofpeace Can someone check this again ?

@Mic92 Mic92 merged commit 8aa3422 into NixOS:master Feb 26, 2019
10 checks passed
@megheaiulian megheaiulian deleted the feature/gitraken-gsettings branch Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants