Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python-jenkins: 1.3.0 -> 1.4.0 #55340

Merged
merged 1 commit into from Feb 8, 2019

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 6, 2019

Motivation for this change

Updates to the most recent version of python-jenkins. It was
originally broken during the auto-update in b4588c6.

The tests could be run by using unittest2 and some dependencies for
the test framwork.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 force-pushed the fix-python-jenkins branch from 4cae9bf to b4e6200 Feb 7, 2019
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 7, 2019

The tests need to be skipped as it doesn't build without the PyPI
tarball as source which doesn't provide the tests.

So using the source at https://git.openstack.org/cgit/openstack/python-jenkins doesn't work?

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Feb 7, 2019

I used the GitHub version (https://github.com/openstack/python-jenkins/) using fetchgit with leaveDotGit = true and it broke with an exception that such a tarball doesn't work for building and a PyPI tarball is recommended.

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Feb 7, 2019

@worldofpeace anything else to add? :)

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Looks great and is probably fine, last thing you could do to check would be to maybe run the tests locally.

Updates to the most recent version of `python-jenkins`. It was
originally broken during the auto-update in b4588c6.

The tests could be run by using `unittest2` and some dependencies for
the test framwork.
@Ma27 Ma27 force-pushed the fix-python-jenkins branch from b4e6200 to fb79b89 Feb 7, 2019
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Feb 7, 2019

@worldofpeace I retried and managed to get the tests running :)

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 7, 2019

Noticed that you didn't pull in all the deps test-requirements.txt which I suppose is fine.

Though I did see some warnings when the tests were running

WARNING:root:JENKINS_API_EXTRA_HEADERS adds these HTTP headers: ['X-Auth: 123', 'X-Key: 234']
.WARNING:root:JENKINS_API_EXTRA_HEADERS adds these HTTP headers: ['X-Auth: 123', 'X-Key: 234']
.....................building False
msg test
revision 66
user unknown
building False
msg test
revision 66
user unknown
building False
msg test
revision 66
user unknown
building False
msg test
revision 66
user unknown

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Feb 7, 2019

Noticed that you didn't pull in all the deps test-requirements.txt which I suppose is fine.

Yeah. Upstream put several development tools into test_requires (like pre-commit) that aren't packagd in nixpkgs and may be helpful in development, but aren't necessary to get the test suite running.

Though I did see some warnings when the tests were running

The code yields warnings if extra headers for Jenkins requests are set. If I understand the code right, this happens in some testcases and is actually fine.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Take 2 :) and tests pass fine 👍

@worldofpeace worldofpeace merged commit 895f9d3 into NixOS:master Feb 8, 2019
10 checks passed
@Ma27 Ma27 deleted the fix-python-jenkins branch Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants