Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] dovecot: fix CVE-2019-3814 #55346

Merged
merged 4 commits into from Feb 11, 2019
Merged

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 6, 2019

Motivation for this change

Stable version of #55343.

I wasn't able to identify which of the commits in https://github.com/dovecot/core/commits/2.3.4.1 are related to which of the changes mentioned in https://dovecot.org/list/dovecot-news/2019-February/000394.html. However, they both seem desirable so I included all three commits.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

@fpletz fpletz commented Feb 7, 2019

Thank you! 👍 on those commits.

The one other change also looks like a useful bugfix to backport to me: dovecot/core@964112f

See dovecot/core@2.3.4...release-2.3.4.

@peti What do you think? IMHO bumping to 2.3.4.1 is preferable here because upstream seems to be doing a good job with their patch releases.

@peti
Copy link
Member

@peti peti commented Feb 8, 2019

IMHO bumping to 2.3.4.1 is preferable here because upstream seems to be doing a good job with their patch releases.

I don't feel too strongly about it. If you prefer doing a full version bump, then I won't object.

r-ryantm and others added 4 commits Feb 11, 2019
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/dovecot/versions

(cherry picked from commit 5a6c4d3)
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/dovecot-pigeonhole/versions

(cherry picked from commit e00bfcd)
@dotlambda dotlambda force-pushed the dovecot-CVE-2019-3814 branch from ff88d8f to 9e431ce Feb 11, 2019
@dotlambda
Copy link
Member Author

@dotlambda dotlambda commented Feb 11, 2019

Since I also prefer a full version bump, that's what I switched to. However, I had to backport a lot of commits.

@peti peti merged commit 109a28a into NixOS:release-18.09 Feb 11, 2019
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants