[18.09] dovecot: fix CVE-2019-3814 #55346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
added
1.severity: security
GrahamcOfBorg
added
10.rebuild-darwin: 1-10
|
Thank you! 👍 on those commits. The one other change also looks like a useful bugfix to backport to me: dovecot/core@964112f See dovecot/core@2.3.4...release-2.3.4. @peti What do you think? IMHO bumping to 2.3.4.1 is preferable here because upstream seems to be doing a good job with their patch releases. |
I don't feel too strongly about it. If you prefer doing a full version bump, then I won't object. |
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dovecot/versions (cherry picked from commit 5a6c4d3)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dovecot-pigeonhole/versions (cherry picked from commit e00bfcd)
(cherry picked from commit b6c96c6)
fixes CVE-2019-3814: https://dovecot.org/list/dovecot-news/2019-February/000394.html (cherry picked from commit d49ffaa)
dotlambda
force-pushed
the
dovecot-CVE-2019-3814
branch
from
ff88d8f to
9e431ce
Compare
|
Since I also prefer a full version bump, that's what I switched to. However, I had to backport a lot of commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Stable version of #55343.
I wasn't able to identify which of the commits in https://github.com/dovecot/core/commits/2.3.4.1 are related to which of the changes mentioned in https://dovecot.org/list/dovecot-news/2019-February/000394.html. However, they both seem desirable so I included all three commits.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)