Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jetbrains editors #55352

Merged
merged 11 commits into from Feb 8, 2019
Merged

Update jetbrains editors #55352

merged 11 commits into from Feb 8, 2019

Conversation

@baracoder
Copy link
Contributor

@baracoder baracoder commented Feb 6, 2019

Notable change: The channels got renamed.

cc maintainers @edwtjo @Mic92 @loskutov @miltador @jgeerds

Motivation for this change

Mainly new rider release, but also updated the rest in the same go.
As always, only tested rider and pycharm-professional, but I am not expecting any problems with the other ones.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jokogr
jokogr approved these changes Feb 8, 2019
Copy link
Contributor

@jokogr jokogr left a comment

Tested IDEA Ultimate, thanks for the PR!

@jokogr jokogr merged commit 0fb3c51 into NixOS:master Feb 8, 2019
10 checks passed
@baracoder baracoder deleted the update-jetbrains branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants