Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional ceph support for libvirt and qemu #55356

Merged
merged 2 commits into from Feb 6, 2019
Merged

Add optional ceph support for libvirt and qemu #55356

merged 2 commits into from Feb 6, 2019

Conversation

@lejonet
Copy link
Contributor

@lejonet lejonet commented Feb 6, 2019

Motivation for this change

Both libvirtd and qemu can use the rbd protocol to interface with a ceph cluster for block devices, however this support has to be enabled at compile time.

The changes are straightforward and only adds an optional argument to enable ceph support for qemu and libvirt packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lejonet lejonet changed the title Ceph libvirt qemu Add optional ceph support for libvirt and qemu Feb 6, 2019
@srhb srhb self-assigned this Feb 6, 2019
@srhb
Copy link
Contributor

@srhb srhb commented Feb 6, 2019

Tested execution, tested that hashes are identical in the default case, thank you!

@srhb srhb merged commit 1c10f5e into NixOS:master Feb 6, 2019
9 checks passed
@lejonet lejonet deleted the ceph-libvirt-qemu branch May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants