Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark merlin and flycheck-ocaml as not broken #55361

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Feb 6, 2019

Motivation for this change

They seem to be working fine on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbaum98 jbaum98 changed the title Mark merlin and flycheck-ocaml as not borken Mark merlin and flycheck-ocaml as not broken Feb 6, 2019
gazally
gazally approved these changes Jul 4, 2019
Copy link
Contributor

@gazally gazally left a comment

I built these packages and tried them out and they do seem to be working fine.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Jul 5, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/27

@timokau
Copy link
Member

@timokau timokau commented Jul 5, 2019

Thanks :)

@timokau timokau merged commit c7276b2 into NixOS:master Jul 5, 2019
9 checks passed
@jbaum98 jbaum98 deleted the merlin-unbroken branch Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants