Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxqt: 0.13.0 -> 0.14.0 #55365

Merged
merged 32 commits into from Feb 14, 2019
Merged

lxqt: 0.13.0 -> 0.14.0 #55365

merged 32 commits into from Feb 14, 2019

Conversation

@romildo
Copy link
Contributor

@romildo romildo commented Feb 6, 2019

Motivation for this change

Update LXQt to version 0.14.0.

Release LXQt 0.14.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 7, 2019

@GrahamcOfBorg build lxqt.compton-conf lxqt.libfm-qt lxqt.liblxqt lxqt.libqtxdg lxqt.libsysstat lxqt.lximage-qt lxqt.lxqt-about lxqt.lxqt-admin lxqt.lxqt-build-tools lxqt.lxqt-config lxqt.lxqt-globalkeys lxqt.lxqt-notificationd lxqt.lxqt-openssh-askpass lxqt.lxqt-panel lxqt.lxqt-policykit lxqt.lxqt-powermanagement lxqt.lxqt-qtplugin lxqt.lxqt-runner lxqt.lxqt-session lxqt.lxqt-sudo lxqt.lxqt-themes lxqt.obconf-qt lxqt.pavucontrol-qt lxqt.pcmanfm-qt lxqt.qps lxqt.qterminal lxqt.qtermwidget lxqt.screengrab

Copy link
Contributor

@worldofpeace worldofpeace left a comment

I saw in a few expressions that patchPhase was used directly and should be using postPatch.
This can be a problem as it will prevent you from adding any patches.

Noticed also because of how they have their CMakeLists.txt set up, you have to add

substituteInPlace CMakeLists.txt \
      --replace "\''${LXQT_TRANSLATIONS_DIR}" "''${out}/share/lxqt/translations"

to pretty much everything.

This is not a blocker to merge but it would be a nice improvement if we didn't have to do that.
Possibly open an issue upstream with possible solutions.

Additionally, I've noticed translations we're broken in Plasma. are they working here?
(possibly non-related issue)

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 11, 2019

I saw in a few expressions that patchPhase was used directly and should be using postPatch.
This can be a problem as it will prevent you from adding any patches.

Fixed.

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 11, 2019

Additionally, I've noticed translations we're broken in Plasma. are they working here?
(possibly non-related issue)

It seems to work well:

$ LANG=pt_BR.UTF-8 result/bin/lxqt-about

lxqt-about-pt

$ LANG=fr_FR.UTF-8 result/bin/lxqt-about

lxqt-about-fr

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 11, 2019

Noticed also because of how they have their CMakeLists.txt set up, you have to add

substituteInPlace CMakeLists.txt \
      --replace "\''${LXQT_TRANSLATIONS_DIR}" "''${out}/share/lxqt/translations"

to pretty much everything.

This is not a blocker to merge but it would be a nice improvement if we didn't have to do that.
Possibly open an issue upstream with possible solutions.

This may be handled later.

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 11, 2019

In pkgs/desktops/lxqt/lxqt-themes/default.nix I have changed lxqt.lxqt-build-tools to lxqt-build-tools.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 11, 2019

😄 Guess I didn't delete that comment after I realized you were doing lxqt.* everywhere else.

Though I also noticed that you were using qt5 directly and I think the qt documentation says that we shouldn't do that.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 11, 2019

Other than that, this looks fine and I'm testing locally now.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 12, 2019

Seems there's an issue at runtime with screengrab.
screenshot from 2019-02-11 19 56 25

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 12, 2019

Seems there's an issue at runtime with screengrab.

Fixed.

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 12, 2019

Though I also noticed that you were using qt5 directly and I think the qt documentation says that we shouldn't do that.

Fixed.

@xeji xeji merged commit 4a340db into NixOS:master Feb 14, 2019
13 checks passed
@romildo romildo deleted the upd.lxqt branch Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants