Skip to content

Diffoscope: update, add guestfs when bloated #55371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2019
Merged

Diffoscope: update, add guestfs when bloated #55371

merged 3 commits into from
Feb 7, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Feb 7, 2019

Motivation for this change

Before, diffoscope would emit a binary diff:

image

Now, diffoscpe emits a nice diff:

image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc grahamc requested a review from FRidh as a code owner February 7, 2019 02:08
@GrahamcOfBorg GrahamcOfBorg requested a review from dezgeg February 7, 2019 02:20
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 7, 2019
@domenkozar domenkozar merged commit 0fb87b5 into NixOS:master Feb 7, 2019
@grahamc grahamc deleted the diffoscope branch February 7, 2019 03:49
@FRidh
Copy link
Member

FRidh commented Feb 7, 2019

This is a really useful improvement, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grahamc @FRidh @domenkozar @GrahamcOfBorg