Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.insert-ordered-containers: fix test phase #55445

merged 1 commit into from Feb 9, 2019


Copy link

@Izorkin Izorkin commented Feb 8, 2019

Motivation for this change

Fix build package haskellPackages.insert-ordered-containers
Used this commit phadej/insert-ordered-containers@73fdf9c
Fix issue #53067

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Copy link

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this patch come from? Is it possible to download it from its origin rather than checking it into our repository?

Copy link
Contributor Author

Izorkin commented Feb 9, 2019

Used official patch - phadej/insert-ordered-containers@73fdf9c
Download patch it from its origin not worked - error patched - not found file .travis.yml

Copy link

peti commented Feb 9, 2019

OK, I see. Thanks for the explanation.

@peti peti merged commit 20dc7bf into NixOS:master Feb 9, 2019
@Izorkin Izorkin deleted the insert-ordered-containers-fix-test branch February 9, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants