Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradio: clean-up #55452

Closed
wants to merge 1 commit into from
Closed

gradio: clean-up #55452

wants to merge 1 commit into from

Conversation

@Anton-Latukha
Copy link
Contributor

@Anton-Latukha Anton-Latukha commented Feb 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Anton-Latukha
Copy link
Contributor Author

@Anton-Latukha Anton-Latukha commented Feb 8, 2019

Side note for @samdroid-apps:

Gradio development was abandoned, and in the same Git repo the complete rewrite in Rust started - the ShortWave. Also main repo was moved to GNOME GitLab. Main dev said to me about the stable release that "Don't expect anything soon, but you will know when the first version is released :)".

So you probably want to support future stable releases of the ShortWave.

jtojnar
jtojnar approved these changes Feb 8, 2019
pkgs/applications/audio/gradio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/gradio/default.nix Show resolved Hide resolved
pkgs/applications/audio/gradio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/gradio/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@jtojnar jtojnar left a comment

bah, did not mean to approve yet

@Anton-Latukha Anton-Latukha force-pushed the gradio-upd branch 2 times, most recently from 3fbc821 to 582785f Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants