Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] nixos/mysql: fix option ensureDatabases #55459

Merged

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Feb 8, 2019

Motivation for this change

Backport to 18.09, stumbled on the issue that was already fixed in master when using current stable 18.09 release.

I am quite sure it should not break existing setups but other opinions are welcome :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The database name needs to be quoted
in case it contains special characters
so the MySQL service does not fail to start.

(cherry picked from commit 429c0bf)
@markuskowa markuskowa merged commit 5225d4b into NixOS:release-18.09 Feb 9, 2019
@fadenb fadenb deleted the mysql_module_dbname_quoting_backport branch February 9, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants