Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.requests: update base16 hash to more conventional base32 hash #55468

Closed
wants to merge 1 commit into from

Conversation

@bhipple
Copy link
Contributor

bhipple commented Feb 9, 2019

nix-hash --type sha256 --to-base32 ea881... converts to this shorter hash, which
is what is printed on prefetch-url validations as well. This does not cause a
package rebuild or hash change.

Motivation for this change

Just doing some standardization and cleanup. Also removed unnecessary quotes on a homepage url.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

…32 hash

nix-hash --type sha256 --to-base32 ea881... converts to this shorter hash, which
is what is printed on prefetch-url validations as well. This does not cause a
package rebuild or hash change.
@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 9, 2019

We usually prefer base16 for Python packages because these can easily be compared against those published on PyPI.

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Feb 9, 2019

It will be nice to have a wide agreement on this. It's not rare for me to solve conflicts between these two styles (master and staging*).

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 9, 2019

That will mostly be resolved once ryantm/nixpkgs-update#106 is fixed.

@bhipple

This comment has been minimized.

Copy link
Contributor Author

bhipple commented Feb 24, 2019

As discussed ryantm/nixpkgs-update#106 (comment) and in the previous comment, @FRidh and I are in favor of just using base32 exclusively for simplicity and consistency with the rest of nixpkgs (and for consistency with non-pypi python packages), in which case this PR can be merged and we should update the python manual guidelines. That said, I doubt either of us feels that strongly about it; any objections @dotlambda?

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 24, 2019

I don't have any objections but feel like this is simply not worth the hassle. Why make a change if the current situation works perfectly fine? It might even break peoples' patches. What we can agree upon is to use base32 hashes in the future.

@@ -20,7 +20,7 @@ buildPythonPackage rec {

meta = with stdenv.lib; {
description = "An authentication handler for using Kerberos with Python Requests.";
homepage = "https://github.com/requests/requests-kerberos";
homepage = https://github.com/requests/requests-kerberos;

This comment has been minimized.

Copy link
@FRidh

FRidh Feb 25, 2019

Member

url are their own type and they're unquoted

@@ -8,7 +8,7 @@ buildPythonPackage rec {

src = fetchPypi {

This comment has been minimized.

Copy link
@FRidh

FRidh Feb 25, 2019

Member

requests is updated in staging-next, so there's no point doing this.

@FRidh FRidh closed this Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.